actions/vault-action
3
0
Fork 0
mirror of https://github.com/hashicorp/vault-action.git synced 2026-04-15 08:16:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix secrets stored in json format (#466)

Browse source 
* fix secrets in json format

* fix actionlint

* add more comments and docs

* revert build.yml test

* add test for json

* fix selector

* fix e2e test

* fix e2e test 2

* remove test

* remove isNaN check

* update changelog
This commit is contained in:
John-Michael Faircloth 2023-06-21 11:55:50 -05:00 • committed by GitHub
parent 62aa8bb4c4
commit b9f4d16071
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 208 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

30
README.md
View file

@ -547,24 +547,22 @@ $ npm run test:integration:basic # Choose one of: basic, enterprise, e2e, e2e-tl
### Running the action locally
You can use the [act](https://github.com/nektos/act) command to test your
changes locally if desired. Unfortunately it is not currently possible to use
uncommitted local changes for a shared workfow. You will still need to push the
changes you would like to validate beforehand. Even if a commit is necessary,
this is still a more detailed and faster feedback loop than waiting for the
action to be executed by Github in a different repository.
changes locally.
Push your changes into a feature branch.
```sh
$ git checkout -b my-feature-branch
$ git commit -m "testing new changes"
$ git push
```
Edit the ./.github/workflows/local-test.yaml file and add any steps necessary
to test your changes. You may have to additionally edit the Vault url, token
and secret path if you are not using one of the provided containerized
instances. The `local-test` job will call the ./integrationTests/e2e/setup.js
script to bootstrap your local Vault instance with secrets.
Edit the ./.github/workflows/local-test.yaml file to use your new feature
branch. You may have to additionally edit the vault url, token and secret path
if you are not using one of the provided containerized instance. Run your
feature branch locally.
Run your feature branch locally:
```sh
$ act workflow_dispatch -j local-test
act workflow_dispatch -j local-test
```
Or use the provided make target which will also spin up a Vault container:
```sh
make local-test
```