From ef9936db81b1ae32aa496bebc3755d68026f6ee8 Mon Sep 17 00:00:00 2001 From: Csaba Feher Date: Mon, 5 May 2025 17:21:08 +0200 Subject: [PATCH] SQSCANGHA-92 Fixing tests round 2 --- .github/workflows/qa-main.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/qa-main.yml b/.github/workflows/qa-main.yml index 7cf003f..772944d 100644 --- a/.github/workflows/qa-main.yml +++ b/.github/workflows/qa-main.yml @@ -21,11 +21,9 @@ jobs: env: SONAR_HOST_URL: http://not_actually_used SONAR_SCANNER_JSON_PARAMS: '{"sonar.scanner.internal.dumpToFile": "./output.properties"}' - - name: Assert failure of previous step - if: steps.invalid_version.outcome == 'success' + - name: Assert run: | - echo "Action with invalid scannerVersion should have failed but succeeded" - exit 1 + ./test/assertFileContains ./output.properties "sonar.projectBaseDir=." argsInputTest: name: > 'args' input @@ -41,7 +39,6 @@ jobs: uses: ./ with: args: -Dsonar.someArg=aValue -Dsonar.anotherArgWithSpaces="Another Value" - scannerVersion: 6.1.0.4477 env: SONAR_HOST_URL: http://not_actually_used SONAR_SCANNER_JSON_PARAMS: '{"sonar.scanner.internal.dumpToFile": "./output.properties"}' @@ -90,7 +87,6 @@ jobs: - name: Run action with projectBaseDir uses: ./ with: - scannerVersion: 6.1.0.4477 args: -Dsonar.scanner.internal.dumpToFile=./output.properties projectBaseDir: ./baseDir env: