From 44de84c3e812ce86b4d57c78b4670cd9e2e9baee Mon Sep 17 00:00:00 2001 From: Julien HENRY Date: Thu, 23 May 2024 08:40:45 +0200 Subject: [PATCH] SQSCANGHA-31 Stop making SONAR_HOST_URL mandatory --- .github/workflows/qa.yml | 17 ----------------- entrypoint.sh | 5 ----- 2 files changed, 22 deletions(-) diff --git a/.github/workflows/qa.yml b/.github/workflows/qa.yml index eec67a7..3e17d55 100644 --- a/.github/workflows/qa.yml +++ b/.github/workflows/qa.yml @@ -45,23 +45,6 @@ jobs: - name: Assert run: | ./test/assertFileContains ./output.properties "sonar.projectBaseDir=.*/baseDir" - sonarHostUrlRequiredTest: - name: > - 'SONAR_HOST_URL' is required - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - with: - token: ${{ secrets.GITHUB_TOKEN }} - - name: Run action without SONAR_HOST_URL - id: runTest - uses: ./ - continue-on-error: true - - name: Previous should have failed - if: ${{ steps.runTest.outcome == 'success'}} - run: | - echo "Expected previous step to fail" - exit 1 dontFailGradleTest: name: > Don't fail on Gradle project diff --git a/entrypoint.sh b/entrypoint.sh index 205251c..5bca08c 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -8,11 +8,6 @@ if [[ -z "${SONAR_TOKEN}" ]]; then echo "============================ WARNING ============================" fi -if [[ -z "${SONAR_HOST_URL}" ]]; then - echo "This GitHub Action requires the SONAR_HOST_URL env variable." - exit 1 -fi - if [[ -n "${SONAR_ROOT_CERT}" ]]; then echo "Adding custom root certificate to java certificate store" rm -f /tmp/tmpcert.pem