From 5a366cee1fc047bcf655559c172cf4ee24f89019 Mon Sep 17 00:00:00 2001 From: marocchino Date: Fri, 27 Dec 2019 08:59:48 +0900 Subject: [PATCH] feat: do not fail when no numbers given --- lib/main.js | 19 ++++++++----------- src/main.ts | 23 +++++++++++------------ 2 files changed, 19 insertions(+), 23 deletions(-) diff --git a/lib/main.js b/lib/main.js index 0f2808d..8f5ac6c 100644 --- a/lib/main.js +++ b/lib/main.js @@ -22,19 +22,16 @@ const comment_1 = require("./comment"); function run() { var _a, _b, _c; return __awaiter(this, void 0, void 0, function* () { + const number = ((_c = (_b = (_a = github_1.context) === null || _a === void 0 ? void 0 : _a.payload) === null || _b === void 0 ? void 0 : _b.pull_request) === null || _c === void 0 ? void 0 : _c.number) || + +core.getInput("number", { required: false }); + if (isNaN(number) || number < 1) { + core.info("no numbers given: skip step"); + return; + } try { const repo = github_1.context.repo; - const number = ((_c = (_b = (_a = github_1.context) === null || _a === void 0 ? void 0 : _a.payload) === null || _b === void 0 ? void 0 : _b.pull_request) === null || _c === void 0 ? void 0 : _c.number) || +core.getInput("number"); - const body = core.getInput("message"); - const githubToken = core.getInput("GITHUB_TOKEN"); - if (isNaN(number)) { - core.setFailed("not found pull request number"); - return; - } - if (!body || !githubToken) { - core.setFailed("invalid input: please check your workflow"); - return; - } + const body = core.getInput("message", { required: true }); + const githubToken = core.getInput("GITHUB_TOKEN", { required: true }); const octokit = new github_1.GitHub(githubToken); const previous = yield comment_1.findPreviousComment(octokit, repo, number); if (previous) { diff --git a/src/main.ts b/src/main.ts index 94b8ef5..8696371 100644 --- a/src/main.ts +++ b/src/main.ts @@ -1,21 +1,20 @@ import * as core from "@actions/core"; import { context, GitHub } from "@actions/github"; import { findPreviousComment, createComment, updateComment } from "./comment"; + async function run() { + const number = + context?.payload?.pull_request?.number || + +core.getInput("number", { required: false }); + if (isNaN(number) || number < 1) { + core.info("no numbers given: skip step"); + return; + } + try { const repo = context.repo; - const number = - context?.payload?.pull_request?.number || +core.getInput("number"); - const body = core.getInput("message"); - const githubToken = core.getInput("GITHUB_TOKEN"); - if (isNaN(number)) { - core.setFailed("not found pull request number"); - return; - } - if (!body || !githubToken) { - core.setFailed("invalid input: please check your workflow"); - return; - } + const body = core.getInput("message", { required: true }); + const githubToken = core.getInput("GITHUB_TOKEN", { required: true }); const octokit = new GitHub(githubToken); const previous = await findPreviousComment(octokit, repo, number); if (previous) {