️ Rollback base_url option

This commit is contained in:
marocchino 2023-04-21 16:20:06 +09:00
parent 1926ccba5e
commit 6be016636e
No known key found for this signature in database
GPG key ID: 326883DCCAF7FFEA
4 changed files with 1 additions and 41 deletions

View file

@ -1,6 +1,5 @@
beforeEach(() => { beforeEach(() => {
process.env["GITHUB_REPOSITORY"] = "marocchino/stick-pull-request-comment" process.env["GITHUB_REPOSITORY"] = "marocchino/stick-pull-request-comment"
process.env["INPUT_BASE_URL"] = "https://api.github.com"
process.env["INPUT_NUMBER"] = "123" process.env["INPUT_NUMBER"] = "123"
process.env["INPUT_APPEND"] = "false" process.env["INPUT_APPEND"] = "false"
process.env["INPUT_RECREATE"] = "false" process.env["INPUT_RECREATE"] = "false"
@ -19,7 +18,6 @@ beforeEach(() => {
afterEach(() => { afterEach(() => {
jest.resetModules() jest.resetModules()
delete process.env["GITHUB_REPOSITORY"] delete process.env["GITHUB_REPOSITORY"]
delete process.env["INPUT_BASE_URL"]
delete process.env["INPUT_OWNER"] delete process.env["INPUT_OWNER"]
delete process.env["INPUT_REPO"] delete process.env["INPUT_REPO"]
delete process.env["INPUT_HEADER"] delete process.env["INPUT_HEADER"]
@ -40,29 +38,10 @@ afterEach(() => {
delete process.env["INPUT_FOLLOW_SYMBOLIC_LINKS"] delete process.env["INPUT_FOLLOW_SYMBOLIC_LINKS"]
}) })
test("baseUrl", async () => {
process.env["INPUT_BASE_URL"] = "https://repo.yourcompany.com"
expect(require("../src/config")).toMatchObject({
baseUrl: "https://repo.yourcompany.com",
pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "",
append: false,
recreate: false,
deleteOldComment: false,
hideOldComment: false,
hideAndRecreate: false,
hideClassify: "OUTDATED",
hideDetails: false,
githubToken: "some-token",
ignoreEmpty: false
})
})
test("repo", async () => { test("repo", async () => {
process.env["INPUT_OWNER"] = "jin" process.env["INPUT_OWNER"] = "jin"
process.env["INPUT_REPO"] = "other" process.env["INPUT_REPO"] = "other"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "jin", repo: "other"}, repo: {owner: "jin", repo: "other"},
header: "", header: "",
@ -81,7 +60,6 @@ test("repo", async () => {
test("header", async () => { test("header", async () => {
process.env["INPUT_HEADER"] = "header" process.env["INPUT_HEADER"] = "header"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "header", header: "header",
@ -100,7 +78,6 @@ test("header", async () => {
test("append", async () => { test("append", async () => {
process.env["INPUT_APPEND"] = "true" process.env["INPUT_APPEND"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -119,7 +96,6 @@ test("append", async () => {
test("recreate", async () => { test("recreate", async () => {
process.env["INPUT_RECREATE"] = "true" process.env["INPUT_RECREATE"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -138,7 +114,6 @@ test("recreate", async () => {
test("delete", async () => { test("delete", async () => {
process.env["INPUT_DELETE"] = "true" process.env["INPUT_DELETE"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -157,7 +132,6 @@ test("delete", async () => {
test("hideOldComment", async () => { test("hideOldComment", async () => {
process.env["INPUT_HIDE"] = "true" process.env["INPUT_HIDE"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -176,7 +150,6 @@ test("hideOldComment", async () => {
test("hideAndRecreate", async () => { test("hideAndRecreate", async () => {
process.env["INPUT_HIDE_AND_RECREATE"] = "true" process.env["INPUT_HIDE_AND_RECREATE"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -195,7 +168,6 @@ test("hideAndRecreate", async () => {
test("hideClassify", async () => { test("hideClassify", async () => {
process.env["INPUT_HIDE_CLASSIFY"] = "OFF_TOPIC" process.env["INPUT_HIDE_CLASSIFY"] = "OFF_TOPIC"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -214,7 +186,6 @@ test("hideClassify", async () => {
test("hideDetails", async () => { test("hideDetails", async () => {
process.env["INPUT_HIDE_DETAILS"] = "true" process.env["INPUT_HIDE_DETAILS"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -234,7 +205,6 @@ describe("path", () => {
test("when exists return content of a file", async () => { test("when exists return content of a file", async () => {
process.env["INPUT_PATH"] = "./__tests__/assets/result" process.env["INPUT_PATH"] = "./__tests__/assets/result"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -254,7 +224,6 @@ describe("path", () => {
test("glob match files", async () => { test("glob match files", async () => {
process.env["INPUT_PATH"] = "./__tests__/assets/*" process.env["INPUT_PATH"] = "./__tests__/assets/*"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -276,7 +245,6 @@ describe("path", () => {
test("when not exists return null string", async () => { test("when not exists return null string", async () => {
process.env["INPUT_PATH"] = "./__tests__/assets/not_exists" process.env["INPUT_PATH"] = "./__tests__/assets/not_exists"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -297,7 +265,6 @@ describe("path", () => {
test("message", async () => { test("message", async () => {
process.env["INPUT_MESSAGE"] = "hello there" process.env["INPUT_MESSAGE"] = "hello there"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",
@ -317,7 +284,6 @@ test("message", async () => {
test("ignore_empty", async () => { test("ignore_empty", async () => {
process.env["INPUT_IGNORE_EMPTY"] = "true" process.env["INPUT_IGNORE_EMPTY"] = "true"
expect(require("../src/config")).toMatchObject({ expect(require("../src/config")).toMatchObject({
baseUrl: "https://api.github.com",
pullRequestNumber: expect.any(Number), pullRequestNumber: expect.any(Number),
repo: {owner: "marocchino", repo: "stick-pull-request-comment"}, repo: {owner: "marocchino", repo: "stick-pull-request-comment"},
header: "", header: "",

View file

@ -11,10 +11,6 @@ github-token:
pull-requests-reason: to create or update PR comment pull-requests-reason: to create or update PR comment
inputs: inputs:
base_url:
description: "base api url. default to: ${{ env.GITHUB_API_URL }}"
default: "${{ env.GITHUB_API_URL }}"
required: false
header: header:
description: "Header to determine if the comment is to be updated, not shown on screen. It can be used when you want to add multiple comments independently at the same time." description: "Header to determine if the comment is to be updated, not shown on screen. It can be used when you want to add multiple comments independently at the same time."
default: "" default: ""

View file

@ -8,7 +8,6 @@ export const pullRequestNumber =
context?.payload?.pull_request?.number || context?.payload?.pull_request?.number ||
+core.getInput("number", {required: false}) +core.getInput("number", {required: false})
export const baseUrl = core.getInput("base_url", {required: true})
export const repo = buildRepo() export const repo = buildRepo()
export const header = core.getInput("header", {required: false}) export const header = core.getInput("header", {required: false})
export const append = core.getBooleanInput("append", {required: true}) export const append = core.getBooleanInput("append", {required: true})

View file

@ -3,7 +3,6 @@ import * as github from "@actions/github"
import { import {
append, append,
getBody, getBody,
baseUrl,
deleteOldComment, deleteOldComment,
githubToken, githubToken,
header, header,
@ -57,7 +56,7 @@ async function run(): Promise<undefined> {
throw new Error("hide and hide_and_recreate cannot be both set to true") throw new Error("hide and hide_and_recreate cannot be both set to true")
} }
const octokit = github.getOctokit(githubToken, {baseUrl}) const octokit = github.getOctokit(githubToken)
const previous = await findPreviousComment( const previous = await findPreviousComment(
octokit, octokit,
repo, repo,