From ef20a3ae63b6c43b73c4811e1c7792c43d63a443 Mon Sep 17 00:00:00 2001 From: "Y. Meyer-Norwood" <106889957+norwd@users.noreply.github.com> Date: Thu, 10 Nov 2022 08:33:11 +1300 Subject: [PATCH] Remove inline comments This is per @engelmi's comment: https://github.com/GoTestTools/gotestfmt-action/pull/10/files#r1017614705 Signed-off-by: Y. Meyer-Norwood <106889957+norwd@users.noreply.github.com> --- index.js | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/index.js b/index.js index 5acb42c..78324b0 100644 --- a/index.js +++ b/index.js @@ -4,50 +4,39 @@ const fs = require("fs") const { execSync } = require("child_process") async function downloadRelease(octokit, os, org, repo, release, token) { + const postfix = `_${os}_amd64.${os === "windows" ? "zip" : "tar.gz"}`; + const tempdir = os === "windows" ? process.env.TEMP + "\\" : "/tmp/"; + const extract = os === "windows" ? "tar -xvf" : "tar -xvzf"; + const archive = `${tempdir}gotestfmt${postfix}`; const releaseAssets = await octokit.rest.repos.listReleaseAssets({ owner: org, repo: repo, release_id: release.id, }) - - // Determine environment specific details, paths etc... - const postfix = `_${os}_amd64.${os === "windows" ? "zip" : "tar.gz"}`; - const tempdir = os === "windows" ? process.env.TEMP + "\\" : "/tmp/"; - const extract = os === "windows" ? "tar -xvf" : "tar -xvzf"; - const archive = `${tempdir}gotestfmt${postfix}`; - - // Search through the latest release assets for an install canidate + for (let asset of releaseAssets.data) { - // Check if the asset name matches the determined postfix console.log("Examining release asset " + asset.name + " at " + asset.browser_download_url + " ...") if (asset.name.endsWith(postfix)) { - // Download the selected release asset archive console.log("Found binary named " + asset.name + " at " + asset.browser_download_url + " , attempting download...") if (token) { - // Use the token to avoid rate limits execSync(`curl -L -o ${archive} -H "Authorization: Bearer ${token}" ${asset.browser_download_url}`) } else { - // Fallback to unauthenticated requests (might get rate limited) execSync(`curl -L -o ${archive} ${asset.browser_download_url}`) } - // Extract the archive into the install target console.log("Unpacking archive file...") core.addPath(process.env.GITHUB_WORKSPACE) process.chdir(process.env.GITHUB_WORKSPACE) execSync(`${extract} "${archive}"`) - // Remove the downloaded asset archive console.log("Removing asset archive...") fs.unlinkSync(archive) - // Successfully installed gotestfmt, return early console.log("Successfully set up gotestfmt.") return } } - // Throw an error if no asset matched the expected postfix throw `No release asset matched postfix '${postfix}'.` }