actions/golangci-lint-action
2
0
Fork 0
mirror of https://github.com/golangci/golangci-lint-action.git synced 2025-12-16 15:38:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat: restrict v6 on v1

Browse source
This commit is contained in:
Fernandez Ludovic 2025-03-12 16:38:49 +01:00
parent b871b4f9de
commit a727475658
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/version.ts
View file

@ -18,8 +18,8 @@ const modVersionRe = /github.com\/golangci\/golangci-lint\s(v\S+)/
const parseVersion = (s: string): Version => { const parseVersion = (s: string): Version => {
if (s == "latest" || s == "") { if (s == "latest" || s == "") {
// TODO(ldez): it should be replaced with an explicit version (ex: v1.64.0) // TODO(ldez): v2: it should be replaced with "return null"
return null return { major: 1, minor: 64, patch: 7 }
} }
const match = s.match(versionRe) const match = s.match(versionRe)
@ -27,6 +27,13 @@ const parseVersion = (s: string): Version => {
throw new Error(`invalid version string '${s}', expected format v1.2 or v1.2.3`) throw new Error(`invalid version string '${s}', expected format v1.2 or v1.2.3`)
} }
// TODO(ldez): v2: to remove.
if (parseInt(match[1]) > 1) {
throw new Error(
`invalid version string '${s}', golangci-lint v2 is not supported by golangci-lint-action v6, you must update to golangci-lint-action v7.`
)
}
return { return {
major: parseInt(match[1]), major: parseInt(match[1]),
minor: parseInt(match[2]), minor: parseInt(match[2]),
@ -115,7 +122,6 @@ const fetchVersionMapping = async (): Promise<VersionMapping> => {
maxRetries: 5, maxRetries: 5,
}) })
try { try {
// TODO(ldez): HEAD should be replaced with an explicit version (ex: v1.64.0).
const url = `https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/assets/github-action-config-v1.json` const url = `https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/assets/github-action-config-v1.json`
const response: httpm.HttpClientResponse = await http.get(url) const response: httpm.HttpClientResponse = await http.get(url)
if (response.message.statusCode !== 200) { if (response.message.statusCode !== 200) {
@ -134,8 +140,13 @@ export async function getVersion(mode: InstallMode): Promise<VersionInfo> {
if (mode == InstallMode.GoInstall) { if (mode == InstallMode.GoInstall) {
const v: string = core.getInput(`version`) const v: string = core.getInput(`version`)
// TODO(ldez): latest should be replaced with an explicit version (ex: v1.64.0). // TODO(ldez): v2: to remove.
return { TargetVersion: v ? v : "latest" } if (v == "latest") {
return { TargetVersion: "v1.64.7" }
}
// TODO(ldez): v2: "v1.64.7" should be replaced with "latest".
return { TargetVersion: v ? v : "v1.64.7" }
} }
const reqVersion = getRequestedVersion() const reqVersion = getRequestedVersion()