actions/golangci-lint-action
2
0
Fork 0
mirror of https://github.com/golangci/golangci-lint-action.git synced 2025-12-20 09:24:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Modify README and action.yml per review

Browse source 
Signed-off-by: Steve Coffman <steve@khanacademy.org>
This commit is contained in:
Steve Coffman 2022-02-24 10:58:57 -05:00
parent 0c22571dad
commit 86c6ed510e
No known key found for this signature in database
GPG key ID: E0A4049327167A8F
2 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
README.md
View file

@ -36,6 +36,7 @@ jobs:
name: lint name: lint
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/setup-go@v2
- uses: actions/checkout@v2 - uses: actions/checkout@v2
- name: golangci-lint - name: golangci-lint
uses: golangci/golangci-lint-action@v2 uses: golangci/golangci-lint-action@v2
@ -52,9 +53,6 @@ jobs:
# Optional: show only new issues if it's a pull request. The default value is `false`. # Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true # only-new-issues: true
# Optional: if set to true then the action will use pre-installed Go.
# skip-go-installation: true
# Optional: if set to true then the action don't cache or restore ~/go/pkg. # Optional: if set to true then the action don't cache or restore ~/go/pkg.
# skip-pkg-cache: true # skip-pkg-cache: true
@ -92,6 +90,7 @@ jobs:
name: lint name: lint
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
steps: steps:
- uses: actions/setup-go@v2
- uses: actions/checkout@v2 - uses: actions/checkout@v2
- name: golangci-lint - name: golangci-lint
uses: golangci/golangci-lint-action@v2 uses: golangci/golangci-lint-action@v2
@ -133,7 +132,6 @@ The action was implemented with performance in mind:
For example, in a repository of [golangci-lint](https://github.com/golangci/golangci-lint) running this action without the cache takes 50s, but with cache takes 14s: For example, in a repository of [golangci-lint](https://github.com/golangci/golangci-lint) running this action without the cache takes 50s, but with cache takes 14s:
* in parallel: * in parallel:
* 13s to download Go
* 4s to restore 50 MB of cache * 4s to restore 50 MB of cache
* 1s to find and install `golangci-lint` * 1s to find and install `golangci-lint`
* 1s to run `golangci-lint` (it takes 35s without cache) * 1s to run `golangci-lint` (it takes 35s without cache)

4
action.yml
View file

@ -20,10 +20,6 @@ inputs:
description: "if set to true and the action runs on a pull request - the action outputs only newly found issues" description: "if set to true and the action runs on a pull request - the action outputs only newly found issues"
default: false default: false
required: true required: true
skip-go-installation:
description: "if set to true then action uses pre-installed Go"
default: false
required: true
skip-pkg-cache: skip-pkg-cache:
description: "if set to true then the action doesn't cache or restore ~/go/pkg." description: "if set to true then the action doesn't cache or restore ~/go/pkg."
default: false default: false