Fix URLs in base url integration test

This commit is contained in:
Josh Gross 2023-11-16 11:22:03 -05:00
parent 4793596d6d
commit 8df72cd04e
No known key found for this signature in database

View file

@ -267,7 +267,7 @@ jobs:
name: base-url set name: base-url set
uses: ./ uses: ./
with: with:
base-url: https://my.github-enterprise-server.com/api/v3 base-url: https://my.github-enterprise-server.com/api/v3/
script: | script: |
const endpoint = github.request.endpoint const endpoint = github.request.endpoint
return endpoint({}).url return endpoint({}).url
@ -276,7 +276,7 @@ jobs:
name: base-url does not override GITHUB_API_URL when not set name: base-url does not override GITHUB_API_URL when not set
uses: ./ uses: ./
env: env:
GITHUB_API_URL: https://my.github-enterprise-server.com/api/v3 GITHUB_API_URL: https://my.github-enterprise-server.com/api/v3/
with: with:
script: | script: |
const endpoint = github.request.endpoint const endpoint = github.request.endpoint
@ -284,18 +284,18 @@ jobs:
result-encoding: string result-encoding: string
- run: | - run: |
echo "- Validating base-url default" echo "- Validating base-url default"
expected="https://api.github.com" expected="https://api.github.com/"
if [[ "${{steps.base-url-default.outputs.result}}" != "$expected" ]]; then if [[ "${{steps.base-url-default.outputs.result}}" != "$expected" ]]; then
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-default.outputs.result}}" echo $'::error::\u274C' "Expected base-url to equal '$expected', got ${{steps.base-url-default.outputs.result}}"
exit 1 exit 1
fi fi
echo "- Validating base-url set to a value" echo "- Validating base-url set to a value"
expected="https://my.github-enterprise-server.com/api/v3" expected="https://my.github-enterprise-server.com/api/v3/"
if [[ "${{steps.base-url-set.outputs.result}}" != "$expected" ]]; then if [[ "${{steps.base-url-set.outputs.result}}" != "$expected" ]]; then
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-set.outputs.result}}" echo $'::error::\u274C' "Expected base-url to equal '$expected', got ${{steps.base-url-set.outputs.result}}"
exit 1 exit 1
fi fi
echo "- Validating base-url not set respects GITHUB_API_URL" echo "- Validating base-url not set respects GITHUB_API_URL"
expected="https://my.github-enterprise-server.com/api/v3" expected="https://my.github-enterprise-server.com/api/v3/"
if [[ "${{steps.base-url-env.outputs.result}}" != "$expected" ]]; then if [[ "${{steps.base-url-env.outputs.result}}" != "$expected" ]]; then
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-env.outputs.result}}" echo $'::error::\u274C' "Expected base-url to equal '$expected', got ${{steps.base-url-env.outputs.result}}"