actions/github-script
3
0
Fork 0
mirror of https://github.com/actions/github-script.git synced 2026-04-07 14:49:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix null handling, covered by integration tests

Browse source 
`core.getInput()` always returns a string, so testing for 'not null'
is always true. This then leads to previews set to an array with
a single empty string, breaking accept-header output.

Updated eslint rules should help avoid this issue in future, and new
integration tests verify that the github client configuration now
reflects the intended configuration options.
This commit is contained in:
Martijn Pieters 2023-03-30 14:53:55 +01:00
parent 806be26275
commit 8d9f8fc050
No known key found for this signature in database
6 changed files with 211 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

3
.eslintrc.yml
View file

@ -6,8 +6,11 @@ extends:
- plugin:@typescript-eslint/eslint-recommended
- plugin:@typescript-eslint/recommended
- prettier/@typescript-eslint
parserOptions:
project: ['tsconfig.eslint.json']
rules:
# '@typescript-eslint/explicit-function-return-type': 0
'@typescript-eslint/no-use-before-define':
- 2
- functions: false
'@typescript-eslint/no-unnecessary-condition': error