mirror of
https://github.com/fluxcd/flux2.git
synced 2026-05-23 01:45:53 +00:00
566bbe6e00
The tilde character is expanded by the shell, not by the Flux CLI, so paths like ~/.ssh/id_ecdsa passed with =value syntax were opened verbatim and failed with a confusing "no such file or directory" error. Detect the leading '~' up front and surface a message pointing users at absolute paths or $HOME instead. Fixes #5591. Signed-off-by: Rafael Peroco <rafaelperoco@gmail.com>
75 lines
2.9 KiB
Go
75 lines
2.9 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func TestCreateGitSecret(t *testing.T) {
|
|
file, err := os.CreateTemp(t.TempDir(), "ca-crt")
|
|
if err != nil {
|
|
t.Fatal("could not create CA certificate file")
|
|
}
|
|
_, err = file.Write([]byte("ca-data"))
|
|
if err != nil {
|
|
t.Fatal("could not write to CA certificate file")
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
args string
|
|
assert assertFunc
|
|
}{
|
|
{
|
|
name: "no args",
|
|
args: "create secret git",
|
|
assert: assertError("name is required"),
|
|
},
|
|
{
|
|
name: "basic secret",
|
|
args: "create secret git podinfo-auth --url=https://github.com/stefanprodan/podinfo --username=my-username --password=my-password --namespace=my-namespace --export",
|
|
assert: assertGoldenFile("./testdata/create_secret/git/secret-git-basic.yaml"),
|
|
},
|
|
{
|
|
name: "ssh key",
|
|
args: "create secret git podinfo-auth --url=ssh://git@github.com/stefanprodan/podinfo --private-key-file=./testdata/create_secret/git/ecdsa.private --namespace=my-namespace --export",
|
|
assert: assertGoldenFile("testdata/create_secret/git/git-ssh-secret.yaml"),
|
|
},
|
|
{
|
|
name: "ssh key with password",
|
|
args: "create secret git podinfo-auth --url=ssh://git@github.com/stefanprodan/podinfo --private-key-file=./testdata/create_secret/git/ecdsa-password.private --password=password --namespace=my-namespace --export",
|
|
assert: assertGoldenFile("testdata/create_secret/git/git-ssh-secret-password.yaml"),
|
|
},
|
|
{
|
|
name: "git authentication with bearer token",
|
|
args: "create secret git bearer-token-auth --url=https://github.com/stefanprodan/podinfo --bearer-token=ghp_baR2qnFF0O41WlucePL3udt2N9vVZS4R0hAS --namespace=my-namespace --export",
|
|
assert: assertGoldenFile("testdata/create_secret/git/git-bearer-token.yaml"),
|
|
},
|
|
{
|
|
name: "git authentication with CA certificate",
|
|
args: fmt.Sprintf("create secret git ca-crt --url=https://github.com/stefanprodan/podinfo --password=my-password --username=my-username --ca-crt-file=%s --namespace=my-namespace --export", file.Name()),
|
|
assert: assertGoldenFile("testdata/create_secret/git/secret-ca-crt.yaml"),
|
|
},
|
|
{
|
|
name: "git authentication with basic auth and bearer token",
|
|
args: "create secret git podinfo-auth --url=https://github.com/stefanprodan/podinfo --username=aaa --password=zzzz --bearer-token=aaaa --namespace=my-namespace --export",
|
|
assert: assertError("user credentials and bearer token cannot be used together"),
|
|
},
|
|
{
|
|
name: "ssh key with tilde path",
|
|
args: "create secret git podinfo-auth --url=ssh://git@github.com/stefanprodan/podinfo --private-key-file=~/.ssh/id_ecdsa --namespace=my-namespace --export",
|
|
assert: assertError(`failed to open private key file: path "~/.ssh/id_ecdsa" starts with '~' which is not expanded; use an absolute path or $HOME`),
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
cmd := cmdTestCase{
|
|
args: tt.args,
|
|
assert: tt.assert,
|
|
}
|
|
cmd.runTestCmd(t)
|
|
})
|
|
}
|
|
}
|