actions/fluxcd-flux2
2
0
Fork 0
mirror of https://github.com/fluxcd/flux2.git synced 2026-05-06 01:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor: cleanup GetArtifactRegistryCredentials error handling

Browse source 
Update fluxcd/pkg/auth to v0.18.0 and simplify error handling for
GetArtifactRegistryCredentials() following the improvements made in
the library.

Similar to fluxcd/image-reflector-controller#786, this removes
unnecessary nil checks as the function now returns errors directly
for unsupported providers.

- Replace authentication code in push_artifact.go with loginWithProvider()
- Remove unnecessary authenticator nil check in oci.go
- Remove unused imports (errors, auth packages)

Signed-off-by: cappyzawa <cappyzawa@gmail.com>
This commit is contained in:
cappyzawa 2025-06-21 14:11:18 +09:00
parent 8ae0aaa46c
commit 4c343893c5
No known key found for this signature in database
4 changed files with 5 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cmd/flux/oci.go
View file

@ -18,7 +18,6 @@ package main
import (
"context"
"errors"
"fmt"
"github.com/google/go-containerregistry/pkg/crane"
@ -38,8 +37,5 @@ func loginWithProvider(ctx context.Context, url, provider string) (crane.Option,
if err != nil {
return nil, fmt.Errorf("could not login to provider %s with url %s: %w", provider, url, err)
}
if authenticator == nil {
return nil, errors.New("unsupported provider")
}
return crane.WithAuth(authenticator), nil
}