actions/fluxcd-flux2
3
0
Fork 0
mirror of https://github.com/fluxcd/flux2.git synced 2026-02-23 08:01:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

make flux uninstall warning much stronger

Browse source 
Nearly sure it is not intended to delete helmreleases.helm.fluxcd.io
HelmReleases when users run `helm uninstall`, but the effect is there
currently, so until the behavior change needed is made clear, a more
strongly worded warning might be appropriate such as this. (See #811)

Is there any way this could be fixed? I would expect `flux uninstall` to
only remove resources that come from Flux v2 CRDs, not Helm Operator HRs
This commit is contained in:
Kingdon Barrett 2021-02-08 12:03:04 -05:00
parent 34edbf469e
commit 49b158181e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/flux/uninstall.go
View file

@ -78,7 +78,7 @@ func uninstallCmdRun(cmd *cobra.Command, args []string) error {
if !uninstallArgs.dryRun && !uninstallArgs.silent { if !uninstallArgs.dryRun && !uninstallArgs.silent {
prompt := promptui.Prompt{ prompt := promptui.Prompt{
Label: fmt.Sprintf("Are you sure you want to delete the %s namespace", rootArgs.namespace), Label: fmt.Sprintf("Are you sure you want to delete the %s namespace (including all Flux CRDs and resources, as well as Flux v1 helm.fluxcd.io HelmReleases)", rootArgs.namespace),
IsConfirm: true, IsConfirm: true,
} }
if _, err := prompt.Run(); err != nil { if _, err := prompt.Run(); err != nil {