actions/codecov-action
3
0
Fork 0
mirror of https://github.com/codecov/codecov-action.git synced 2026-02-11 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Update validation

Browse source
This commit is contained in:
Tom Hu 2021-07-22 12:55:04 -07:00
parent 53f686aaf8
commit 0bbb08247a
No known key found for this signature in database
GPG key ID: F7E832BD316D5603
4 changed files with 42 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -2,6 +2,7 @@
### Fixes ### Fixes
- Underlying uploader fixes issues with tokens not being sent properly for users seeing - Underlying uploader fixes issues with tokens not being sent properly for users seeing
`Error!: Error: Error uploading to https://codecov.io: Error: Error uploading to Codecov: Error: Not Found` `Error!: Error: Error uploading to https://codecov.io: Error: Error uploading to Codecov: Error: Not Found`
- #440 fix: Validation ordering
## 2.0.1 ## 2.0.1
### Fixes ### Fixes

33
dist/index.js vendored
View file

@ -13061,22 +13061,23 @@ const verify = (filename) => __awaiter(void 0, void 0, void 0, function* () {
else { else {
setFailure('Codecov: Error validating SHASUM signature', true); setFailure('Codecov: Error validating SHASUM signature', true);
} }
// Verify uploader const calculateHash = (filename) => __awaiter(void 0, void 0, void 0, function* () {
const uploaderSha = external_crypto_.createHash(`sha256`); const stream = external_fs_.createReadStream(filename);
const stream = external_fs_.createReadStream(filename); const uploaderSha = external_crypto_.createHash(`sha256`);
return yield stream stream.pipe(uploaderSha);
.on('data', (data) => { return new Promise((resolve, reject) => {
uploaderSha.update(data); stream.on('end', () => resolve(`${uploaderSha.digest('hex')} ${uploaderName}`));
}).on('end', () => __awaiter(void 0, void 0, void 0, function* () { stream.on('error', reject);
const hash = `${uploaderSha.digest('hex')} ${uploaderName}`; });
if (hash !== shasum) { });
setFailure('Codecov: Uploader shasum does not match\n' + const hash = yield calculateHash(filename);
`uploader hash: ${hash}\npublic hash: ${shasum}`, true); if (hash === shasum) {
} core.info(`==> Uploader SHASUM verified (${hash})`);
else { }
core.info('==> Uploader SHASUM verified'); else {
} setFailure('Codecov: Uploader shasum does not match -- ' +
})); `uploader hash: ${hash}, public hash: ${shasum}`, true);
}
} }
catch (err) { catch (err) {
setFailure(`Codecov: Error validating uploader: ${err.message}`, true); setFailure(`Codecov: Error validating uploader: ${err.message}`, true);

2
dist/index.js.map vendored
View file

File diff suppressed because one or more lines are too long

41
src/validate.ts
View file

@ -44,24 +44,29 @@ const verify = async (filename: string) => {
setFailure('Codecov: Error validating SHASUM signature', true); setFailure('Codecov: Error validating SHASUM signature', true);
} }
// Verify uploader const calculateHash = async (filename: string) => {
const uploaderSha = crypto.createHash(`sha256`); const stream = fs.createReadStream(filename);
const stream = fs.createReadStream(filename); const uploaderSha = crypto.createHash(`sha256`);
return await stream stream.pipe(uploaderSha);
.on('data', (data) => {
uploaderSha.update(data); return new Promise((resolve, reject) => {
}).on('end', async () => { stream.on('end', () => resolve(
const hash = `${uploaderSha.digest('hex')} ${uploaderName}`; `${uploaderSha.digest('hex')} ${uploaderName}`,
if (hash !== shasum) { ));
setFailure( stream.on('error', reject);
'Codecov: Uploader shasum does not match\n' + });
`uploader hash: ${hash}\npublic hash: ${shasum}`, };
true,
); const hash = await calculateHash(filename);
} else { if (hash === shasum) {
core.info('==> Uploader SHASUM verified'); core.info(`==> Uploader SHASUM verified (${hash})`);
} } else {
}); setFailure(
'Codecov: Uploader shasum does not match -- ' +
`uploader hash: ${hash}, public hash: ${shasum}`,
true,
);
}
} catch (err) { } catch (err) {
setFailure(`Codecov: Error validating uploader: ${err.message}`, true); setFailure(`Codecov: Error validating uploader: ${err.message}`, true);
} }